Skip to content

Conversation

@fernando-cortez
Copy link
Contributor

@fernando-cortez fernando-cortez commented Sep 3, 2024

Description

This PR updates the pickup approach and integrates animations to be played out when picking up, dropping, & throwing a pickupable object.

To test: load into game scene and pick up/drop/toss the spawned pickupable object (with multiple clients connected).
You're able to grab another client's held item 😄

Issue Number(s)

MTT-9016

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • [ N/A ] Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez requested a review from a team as a code owner September 3, 2024 21:33
@Elfi0Kuhndorf
Copy link
Contributor

Functionality-wise looks good to me now! :D I also noticed that you can steal someone's object from their hands which is great, I think it is a fun extra interaction!

We should possibly change the Interact button to something else than "E" so that it is easier to move while also holding E for a throw. E.g. we could use the LC from the mouse or ENTER on the keyboard. But I think for now it works well.

Elfi0Kuhndorf
Elfi0Kuhndorf previously approved these changes Sep 4, 2024
Base automatically changed from feat/distributed-authority-sample/locomotion-animation-integration to develop September 4, 2024 14:24
@fernando-cortez fernando-cortez dismissed Elfi0Kuhndorf’s stale review September 4, 2024 14:24

The base branch was changed.

Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fernando-cortez fernando-cortez merged commit 0a086af into develop Sep 4, 2024
@fernando-cortez fernando-cortez deleted the feat/distributed-authority-sample/interactions-animation-integration branch September 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants