-
Notifications
You must be signed in to change notification settings - Fork 136
Multiplayer Use cases - Unity 6 update #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore: updated multiplayer tools package to 2.2.0, and Tutorial framework package to 4.0.1
…be deprecated and throws warnings
…Multiplayer Play Mode fix: fixed "Build Profile" window not beng clickable during the last page of each tutorial, in which users were hinted to make build
|
Also I noticed that when maximizing the game window the UI on the right side is too small now ... that is something which should be changed (maybe I can do that after Unite and when I am back). It confused me because I thought I set it up in a way that it would scale with the size of the window, but maybe it does not work on Unity 6 for some reason :/ |
|
Otherwise it looks good the functionality of all scenes works with MPPM as well. |
Nice catch, Elfi! Unfortunately, it seems that the issue is caused by the "Play mode scenarios" feature which "steals" the visual element class name of the Play Mode button ( This causes the tutorial framework to no longer recognize it. The problem here is that this means that any project with an IET that asks to enter play mode will break the moment a user installs the package that makes that play mode scenarios feature to appear (which is In fact, you can see that the Small Scale template doesn't suffer from this problem as it uses version 1.2.2 of MPPM.
I think we can solve this issue in 2 ways:
and like this when it is installed:
While (2) seems the most straightforward option here, it brings up the issue of "what if another package places something there too?" Should this be solved at an IET level? (@[email protected] ) cc @MorwennaG for awareness. |
|
^ I tagged the wrong Guillaume, the correct one is @UnityGuillaume |
|
Unsure what is the most generic way to handle this, or even if the IET package should handle it, as this is in effect outside of the IET control (an external package modify the UI that was used to author the IET). I think it should more be a general design rule to not modify existing UI element no matter what, as this could be a problem for other tool than IET? (automated tools that try to find the play button, or want to observe it for interaction etc.) On the IET side, the only path I see is by relaxing the matching process to fallback on the "best guess" if a perfect match isn't found? The screenshot show that it does also look for the name We could offer a special case to select the Play button, but that seems like opening a can of worms (why only the play button and not other common element of the UI) so the "good enough match" system may be the way to go |
…to changes to the UI in Unity 6
…logies/com.unity.multiplayer.samples.bitesize into sample/use-cases-to-unity-6
|
@Elfi0Kuhndorf for the purpose of unblocking this PR, I made it so that both the "--left" and "--middle" classes are used to find the Play button. Could you re-review? |
|
@hammerlerobi made me realize that we can solve this by using just the name of the play button (which is always "Play") and removing the classes entirely. Side topic for @UnityGuillaume: in the red circle there are the "-+" buttons that allow you to add/remove elements from the
|
|
@RikuTheFuffs looks like it wasn't reported in our bug list, added an issue for it, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now!





Description
NOTE: this PR is targeting
mainbut it should targetdevelop. However develop is currently behindmainbecause of merge conflicts with the Distributed Authority sample, so we'll need to fix that first, then switch the target branch in this PR.Issue Number(s)
Contribution checklist
How to validate