Skip to content

feat: distributed authority sample collisions + damage [MTT-9026] #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 30, 2024
Merged

feat: distributed authority sample collisions + damage [MTT-9026] #211

merged 17 commits into from
Aug 30, 2024

Conversation

@fernando-cortez
Copy link
Contributor

@fernando-cortez fernando-cortez commented Aug 26, 2024 •
edited
Loading

Description

This PR imports trimmed down base classes from the Asteroids project to enable messages to be sent from owning clients to non-owning clients & vice-versa when a physics collision is detected.

Included in this PR too is a refactored, more re-usable PhysicsController, separating the input processing + locomotion aspects of the class.

Issue Number(s)

MTT-9026

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • [ N/A ] Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez
asmdefs generated with dependencies mapped
3c2d04f
@fernando-cortez
one unnecessary dependency removed
ad2404d
@fernando-cortez
renaming asmdefs & adding input assemblyinfo
c7787f2
@fernando-cortez
avatar-side pickup/toss of pickupable object
609c59d
@fernando-cortez
adding a pickupable object, EnvironmentTransform, to scene with a spa…
d7e70f8 
…wner
@fernando-cortez
adding explicitly inputsystem to player assembly
301856b
@fernando-cortez
merge feat/distributed-authority-sample/assembly-definitions
57d5f19
@fernando-cortez
Merge branch 'develop' into feat/distributed-authority-sample/avatar-…
3884131 
…interactions
@fernando-cortez
destructible object created, physics scripts imported
985d6d6
@fernando-cortez
phyics base classes refactor & damage dealt to DestructibleObject
5f12e5c
@fernando-cortez
adding SO for player movement
726d1c4
@fernando-cortez
merge develop
d18cff2
@fernando-cortez
prefabs updated post-merge, debug log removed
32b1160
@fernando-cortez
removing unused class, cooldown on damage, cleanup
c28ee10
@fernando-cortez fernando-cortez marked this pull request as ready for review August 28, 2024 20:38
@fernando-cortez fernando-cortez requested a review from a team as a code owner August 28, 2024 20:38
NoelStephensUnity
NoelStephensUnity previously approved these changes Aug 29, 2024
View reviewed changes
Copy link

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you brought over some of the foundational classes.
Would like to get your feedback on those ... what you liked... didn't like etc.
Other than that... the rest looks good to me.
👍

@fernando-cortez fernando-cortez merged commit 5d01bf9 into develop Aug 30, 2024
@fernando-cortez fernando-cortez deleted the feat/distributed-authority-sample/physics-collisions-damage branch August 30, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fernando-cortez @NoelStephensUnity