Skip to content

[MTT-9001] Feat/distributed authority sample camera system #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Sep 6, 2024
Merged

[MTT-9001] Feat/distributed authority sample camera system #210

merged 34 commits into from
Sep 6, 2024

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

Description

This PR implements a camera system for our avatar. The spawned avatar gets connected during runtime.
It is possible to zoom and rotate around the character while holding the RMB and moving the mouse

Issue Number(s)

https://jira.unity3d.com/browse/MTT-9001

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner August 22, 2024 13:57
@Elfi0Kuhndorf Elfi0Kuhndorf self-assigned this Aug 27, 2024
@unity-cla-assistant
Copy link

unity-cla-assistant commented Aug 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

fernando-cortez
fernando-cortez reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly stylistic changes to be made!

@Elfi0Kuhndorf
Addressed feedback, making functions internal instead of public and a…
8d4b412 
…ccessing as well as utilizing its transform instead of complete AvatarTransform component

also set speedMultiplier of Main camera to 3 because it feels nicer
@Elfi0Kuhndorf
Merge branch 'develop' into feat/DistributedAuthoritySample-camera-sy…
a9422a2 
…stem
fernando-cortez
fernando-cortez suggested changes Sep 4, 2024
View reviewed changes
fernando-cortez
fernando-cortez previously approved these changes Sep 5, 2024
View reviewed changes
@fernando-cortez fernando-cortez merged commit 8627537 into develop Sep 6, 2024
@fernando-cortez fernando-cortez deleted the feat/DistributedAuthoritySample-camera-system branch September 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Elfi0Kuhndorf Elfi0Kuhndorf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Elfi0Kuhndorf @unity-cla-assistant @fernando-cortez @glabute