Dgs/unity 6 update

[RikuTheFuffs]

Description

• Updated Dedicated Game Server sample to Unity 6, and related packages to 1.1.0

Issue Number(s)

• https://jira.unity3d.com/browse/MTT-8617

Contribution checklist

• Tests have been added for the project and/or any internal package
• Release notes have been added to the project changelog file
• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• JIRA ticket ID is in the PR title or at least one commit message
• Include the ticket ID number within the body message of the PR to create a hyperlink

How to test

1. Clone this branch
2. Open multiplayer play mode
3. Set the current editor role as client or server
4. Enable 2 virtual players and set their role so that there are exactly 2 clients and 1 server (inlcuding the main editor)
5. Enter play mode
6. Check that no errors show up in the console

[unity-cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ RikuTheFuffs
❌ Paolo Abela

---

Paolo Abela seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[RikuTheFuffs]

I think tests are failing because of a method that throws an error during the build:

NotSupportedException: Use GetMultiplayerRoleForBuildProfile instead.
Unity.Multiplayer.Editor.EditorMultiplayerRolesManager.SetMultiplayerRoleForBuildTarget (UnityEditor.Build.NamedBuildTarget namedBuildTarget, Unity.Multiplayer.MultiplayerRoleFlags mask) (at ./Library/PackageCache/com.unity.dedicated-server/MultiplayerRoles/Editor/EditorMultiplayerRolesManager.cs:163)
Unity.DedicatedGameServerSample.Editor.BuildProcessor.BuildServer (UnityEditor.BuildTarget target, System.String locationPathName, System.Boolean exitApplicationOnFailure) (at Assets/Scripts/Editor/BuildProcessor.cs:135)
Unity.DedicatedGameServerSample.Editor.BuildHelpers.BuildAllEnabledServers () (at Assets/Scripts/Editor/BuildHelpers.cs:138)
Unity.DedicatedGameServerSample.Editor.BuildHelpers.BuildEnabledServersAndClients () (at Assets/Scripts/Editor/BuildHelpers.cs:113)

We'll probably have to replace SetMultiplayerRoleForBuildTarget with SetMultiplayerRoleForBuildProfile and create new build profiles + some custom logic to retrieve them at build time.

[RikuTheFuffs]

I removed the deprecated code, and tried to build locally from the editor: It works as expected:

But I still see that the build jobs fail on Yamato, probably due to some Unity 6 Yamato shenanigans. I'll ask the Yamato team to see if this is a known issue and how to overcome it.

EDIT: asked here

[Elfi0Kuhndorf]

I get the following errors for the two clients:

Assertion failed on expression: 'scriptedImporterClass == SCRIPTING_NULL || uniqueDomainId == MonoDomainGetUniqueId()' (this one already upon the extra editor windows getting opened, both virtual players, so possibly connected to MPPM)

Assertion failed on expression: '!(InstanceID_AsSInt32Ref(instanceID) & 1)' (this one I get when entering play mode)

[fernando-cortez]

Forgot to mention in my review, but for the URP assets & UI Toolkit changes, we should verify with TAs.

[RikuTheFuffs]

I get the following errors for the two clients:

@Elfi0Kuhndorf what is the stack trace? If these errors are not generated by the code of this project, we can ignore them. (that menasv they're generated by the engine or by packages)

[RikuTheFuffs]

Forgot to mention in my review, but for the URP assets & UI Toolkit changes, we should verify with TAs.

They're automatic changes due to the upgrade to Unity 6 and the cosnequent re-serialization of assets, they weren't changed manually.