fix: releasing Addressables handle on OnDestroy in DynamicAddressablesNetworkPrefabs Preloading scene #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug was discovered when testing Preloading scene where the Dynamic Prefab loading in Preloading scene was null, due to the Addressables handle being released as soon as the prefab was loaded.
The Release call was moved to this MonoBehaviour's OnDestroy method.
Issue Number(s)
N/A
To Test:
Load 00_Preloading Dynamic Prefabs scene.
Host on one instance.
See that the warnings shared below don't appear on console.
Verify that the same is for a joining client.
Contribution checklist