Skip to content

Conversation

@fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented May 20, 2024

Description

A bug was discovered when testing Preloading scene where the Dynamic Prefab loading in Preloading scene was null, due to the Addressables handle being released as soon as the prefab was loaded.

The Release call was moved to this MonoBehaviour's OnDestroy method.

Issue Number(s)

N/A

To Test:
Load 00_Preloading Dynamic Prefabs scene.
Host on one instance.
See that the warnings shared below don't appear on console.
Verify that the same is for a joining client.

Screenshot 2024-05-21 at 14 28 33

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ N/A ] JIRA ticket ID is in the PR title or at least one commit message
  • [ N/A ] Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez marked this pull request as ready for review May 21, 2024 18:33
@fernando-cortez fernando-cortez requested a review from a team as a code owner May 21, 2024 18:33
@fernando-cortez fernando-cortez merged commit a081eb3 into develop May 22, 2024
@fernando-cortez fernando-cortez deleted the fix/dynamicaddressablesnetworkprefabs-preloading-release branch May 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants