Skip to content

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented May 7, 2024

Description

Upgraded 2D Space Shooter to NGO 1.8.1

  • added the new Rpc attribute
  • added OnConnectionEvent

I DID NOT add the new InstantiateAndSpawn to it yet. I tried to add it to the Spawner.cs script, but it did not work well due to a NetworkObjectPool being used
e.g. GameObject go = m_ObjectPool.GetNetworkObject(m_AsteroidPrefab.gameObject); does not work. I am not sure if I should include InstantiateAndSpawn here?

Issue Number(s)

MTT-8498

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf self-assigned this May 7, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review May 8, 2024 07:47
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner May 8, 2024 07:47
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick aside, looks good to go!

@Elfi0Kuhndorf Elfi0Kuhndorf merged commit eb69754 into develop May 15, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the feature/upgrade-ngo-1.81 branch May 15, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants