Skip to content

Fix/resolving todos and suggestions in comments 2dspaceshooter #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 30, 2024
Merged

Fix/resolving todos and suggestions in comments 2dspaceshooter #167

merged 11 commits into from
Apr 30, 2024

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented Apr 23, 2024 •
edited
Loading

Description

Fixing leftover Todos and comment suggestions in Shipcontrol.cs and Bullet.cs scripts

  • Improving performance from explosion particle spawn on DestroyBullet() through pooling (Creation of Pool script)
  • Inserting coroutine
  • Resetting buffs in Shipcontrol.cs when Ship health goes to 0

Issue Number(s)

MTT-8365

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf self-assigned this Apr 23, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review April 24, 2024 15:02
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner April 24, 2024 15:02
RikuTheFuffs
RikuTheFuffs requested changes Apr 25, 2024
View reviewed changes
RikuTheFuffs
RikuTheFuffs requested changes Apr 30, 2024
View reviewed changes
@RikuTheFuffs RikuTheFuffs enabled auto-merge (squash) April 30, 2024 15:06
@RikuTheFuffs RikuTheFuffs merged commit faac280 into develop Apr 30, 2024
@RikuTheFuffs RikuTheFuffs deleted the fix/resolving-todos-and-suggestions-in-comments-2dspaceshooter branch April 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikuTheFuffs RikuTheFuffs RikuTheFuffs approved these changes

@bastienunity bastienunity Awaiting requested review from bastienunity

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

@Elfi0Kuhndorf Elfi0Kuhndorf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Elfi0Kuhndorf @RikuTheFuffs