-
Notifications
You must be signed in to change notification settings - Fork 136
Fix: Client Driven Ghost Static Ingredients on Late join [MTT-4505] #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Elfi0Kuhndorf
merged 17 commits into
develop
from
fix/MTT-4505-static-ingredients-late-join
Apr 17, 2024
Merged
Fix: Client Driven Ghost Static Ingredients on Late join [MTT-4505] #157
Elfi0Kuhndorf
merged 17 commits into
develop
from
fix/MTT-4505-static-ingredients-late-join
Apr 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce objects there to copy behavior in Boss Room and to keep it consistent between different clients including late joiners
RikuTheFuffs
requested changes
Mar 12, 2024
RikuTheFuffs
requested changes
Mar 14, 2024
RikuTheFuffs
requested changes
Mar 15, 2024
…ion to NetworkObjectSpawner
RikuTheFuffs
requested changes
Mar 15, 2024
… issue old blue ingredient prefab for some reason did not save blue color setting even though adjusting and saving it on prefab directly (possibly bug?)
Contributor
fernando-cortez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small updates to make!
dragging GameObjects above art section in scene + code adjustments in NetworkObjectSpawner
fernando-cortez
approved these changes
Apr 17, 2024
RikuTheFuffs
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To remove the inconsistent behavior for late joiners (ingredients existing on late joiners side even though they were removed by another player) the in-scene placed objects got removed and spawners similar to the ones in Boss Room got added to achieve consistent behavior between clients
How to test:
Issue Number(s)
MTT-4505
Contribution checklist