Skip to content

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

Description

To remove the inconsistent behavior for late joiners (ingredients existing on late joiners side even though they were removed by another player) the in-scene placed objects got removed and spawners similar to the ones in Boss Room got added to achieve consistent behavior between clients

How to test:

  1. Open Client Driven Sample
  2. Create a build or clone
  3. Join as host and bring one ingredient to goal with host
  4. Late-join from other build/editor and check that scene looks identical for both players

Issue Number(s)

MTT-4505

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

…ce objects

there to copy behavior in Boss Room and to keep it consistent between different clients including late joiners
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner March 12, 2024 13:14
@unity-cla-assistant
Copy link

unity-cla-assistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as draft March 12, 2024 13:14
@Elfi0Kuhndorf Elfi0Kuhndorf added bug Something isn't working good first issue Good for newcomers labels Mar 12, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review March 15, 2024 16:23
@RikuTheFuffs RikuTheFuffs self-requested a review April 9, 2024 11:01
Elfi0Kuhndorf and others added 2 commits April 9, 2024 13:23
… issue

old blue ingredient prefab for some reason did not save blue color setting even though adjusting and saving it on prefab directly (possibly bug?)
Copy link
Contributor

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small updates to make!

dragging GameObjects above art section in scene + code adjustments in NetworkObjectSpawner
@Elfi0Kuhndorf Elfi0Kuhndorf removed the request for review from RikuTheFuffs April 12, 2024 12:50
@Elfi0Kuhndorf Elfi0Kuhndorf merged commit 559f667 into develop Apr 17, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the fix/MTT-4505-static-ingredients-late-join branch April 17, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants