Skip to content

fix the no fire sound problem #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 11, 2023
Merged

fix the no fire sound problem #138

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6065718
fix the no fire sound problem
Alexander5421 Sep 23, 2023
e214ad8
Merge branch 'develop' into fix/client-add-firesound
fernando-cortez Sep 25, 2023
4431226
Merge branch 'develop' into fix/client-add-firesound
fernando-cortez Nov 20, 2023
fa20985
Merge branch 'develop' into fix/client-add-firesound
fernando-cortez Nov 20, 2023
ddfdf53
Merge branch 'develop' into fix/client-add-firesound
fernando-cortez Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Basic/2DSpaceShooter/Assets/Scripts/ShipControl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,7 @@ public void TakeDamage(int amount)

void Fire(Vector3 direction)
{
fireSound.Play();

PlayFireSoundClientRpc();
var damage = 5;
if (QuadDamageTimer.Value > NetworkManager.ServerTime.TimeAsFloat)
{
Expand Down Expand Up @@ -499,6 +498,13 @@ void OnCollisionEnter2D(Collision2D other)
}
}

// --- ClientRPCs ---

[ClientRpc]
void PlayFireSoundClientRpc()
{
fireSound.Play();
}
// --- ServerRPCs ---

[ServerRpc]
Expand Down