Skip to content

Conversation

smitdylan2001
Copy link
Contributor

Some simple performance improvements. Would be good to take these into new commits as well and could be backported Since nothing changed for the end user I did not make changelog edits. Is that necessary?

Improved CPU performance with:

  • Re order vector calculations
  • Simplify LINQ statements
  • Use TryGetComponent to reduce garbage allocation
  • Use AddRange instead of Add in loops

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
Improve CPU performance with minor fixes


Testing status

Describe what manual/automated tests were performed for this PR
No major changes made to code


Comments to reviewers

Notes for the reviewers you have assigned.
Do I need to add changelog changes?
Can this be backported?

Some simple performance improvements. Would be good to take these into new commits as well and could be backported Since nothing changed for the end user I did not make changelog edits. Is that necessary?

Improved CPU performance with:
- Re order vector calculations
- Simplify LINQ statements
- Use TryGetComponent to reduce garbage allocation
- Use AddRange instead of Add in loops
PierreGac pushed a commit to PierreGac/PostProcessing that referenced this pull request Sep 12, 2022
@sebastienlagarde sebastienlagarde self-requested a review September 14, 2022 15:48
@sebastienlagarde sebastienlagarde merged commit 32c690b into Unity-Technologies:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants