Skip to content

Build ByteCode by make instead of shellExec #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

ladisgin
Copy link
Member

No description provided.

@ladisgin ladisgin linked an issue Jun 16, 2022 that may be closed by this pull request
@ladisgin ladisgin force-pushed the ladisgin/processing_exports branch from 2aafcbf to 18f1f66 Compare June 16, 2022 16:09
Copy link
Collaborator

@operasfantom operasfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can't figure out how these changes solve the main problem. Maybe you should have added a short explanation of what is going on underneath.

@ladisgin ladisgin force-pushed the ladisgin/processing_exports branch from 18f1f66 to 9000c6b Compare June 17, 2022 07:27
@ladisgin
Copy link
Member Author

ladisgin commented Jun 17, 2022

We use shell exec for build bytecode and pass argument to it by string.
For example compile command
clang -DEXPORT= main.c here EXPORT empty
it parse to exec: clang
args: -DEXPORT="", main.c
when we pass this arguments shell exec real command will be like
"clang" "-DEXPORT=\"\"" "main.c" -> clang -DEXPORT=\"\" main.c here EXPORT empty string

@operasfantom
Copy link
Collaborator

when we pass this arguments shell exec real command will be like "clang" "-DEXPORT=\"\"" "main.c" -> clang -DEXPORT=\"\" main.c here EXPORT empty string

Now the reason is clear for me, thanks. Will approve PR soon.

@operasfantom operasfantom self-requested a review June 17, 2022 08:17
@ladisgin ladisgin merged commit 38f9692 into main Jun 17, 2022
@sava-cska sava-cska deleted the ladisgin/processing_exports branch June 17, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect capture of the empty macros from CMakeLists.txt setup
2 participants