-
Notifications
You must be signed in to change notification settings - Fork 104
Add a page on predictive distributions #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview the changes: https://turinglang.org/docs/pr-previews/658 |
0458692 to
3fc1674
Compare
d635e51 to
40c8171
Compare
40c8171 to
2afb11e
Compare
nsiccha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the typo and the math for the posterior predictive distribution.
| This means that when the model is evaluated, it will sample a new value for `X`. | ||
|
|
||
| ```{julia} | ||
| predictive_model = decondition(model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if we don't decondition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't decondition then it'll just be a plain old observation, so it won't be sampled again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a line to make that super clear!
nsiccha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - but I had a final thought, which I however don't want to hold up this PR: aren't data always plural?
Yes, supposedly ... but I checked and I don't think I messed it up :D was there a particular line? |
Oh! I forgot to respond! |
Only 3 years late (!), but closes #332.
View here: https://turinglang.org/docs/pr-previews/658/usage/predictive-distributions/