Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 9, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Preview the changes: https://turinglang.org/docs/pr-previews/658
Please avoid using the search feature and navigation bar in PR previews!

Copy link

@nsiccha nsiccha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo and the math for the posterior predictive distribution.

This means that when the model is evaluated, it will sample a new value for `X`.

```{julia}
predictive_model = decondition(model)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we don't decondition?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't decondition then it'll just be a plain old observation, so it won't be sampled again

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a line to make that super clear!

@penelopeysm penelopeysm requested a review from nsiccha November 18, 2025 18:29
Copy link

@nsiccha nsiccha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - but I had a final thought, which I however don't want to hold up this PR: aren't data always plural?

@penelopeysm
Copy link
Member Author

aren't data always plural

Yes, supposedly ... but I checked and I don't think I messed it up :D was there a particular line?

@penelopeysm penelopeysm merged commit a13ec14 into main Nov 21, 2025
0 of 2 checks passed
@penelopeysm penelopeysm deleted the py/predict branch November 21, 2025 19:06
github-actions bot added a commit that referenced this pull request Nov 21, 2025
@nsiccha
Copy link

nsiccha commented Nov 21, 2025

Yes, supposedly ... but I checked and I don't think I messed it up :D was there a particular line?

Oh! I forgot to respond!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add predict to online documentation

3 participants