-
Notifications
You must be signed in to change notification settings - Fork 104
Update prob query section of the doc following the removal of prob macro
#440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sunxd3 -- it looks good.
Re the question above, if one wants to change the data inside a posterior model, he will have to call decondition and then condition again. This is arguably the correct behaviour because likelihood functions are not functions of data but functions of parameters.
torfjelde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though one minor change:)
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Ref TuringLang/DynamicPPL.jl#604
I couldn't find a way to replicate the behavior of
probmacro. Particularly, givenFor
loglikelihood(model2, (...))will still usex=1.0to compute the loglikelihood.So I did some simplification, let me know the thoughts.