Skip to content

Change Selector.tag from Ref{Symbol} to Symbol #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

Change Selector.tag from Ref{Symbol} to Symbol #726

merged 1 commit into from
Mar 22, 2019

Conversation

@KDr2
Copy link
Member

@KDr2 KDr2 commented Mar 22, 2019

For #567 and the review comments of #720.

@KDr2 KDr2 requested review from mohdibntarek and yebai March 22, 2019 03:15
@KDr2 KDr2 mentioned this pull request Mar 22, 2019
Merged
mohdibntarek
mohdibntarek approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@mohdibntarek mohdibntarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Might be worth increasing the tolerance in the failing tests before merging, just to pass all tests.

@KDr2
Copy link
Member Author

KDr2 commented Mar 22, 2019

There are 3 random failures:

  1. test\randomMeasures.jl\sbs.jl:85
  Expression: l2 < 0.05
   Evaluated: 0.07110734657557963 < 0.05
  1. test\randomMeasures.jl\sbs.jl:86
  Expression: discr < 0.2
   Evaluated: 0.22442443187120475 < 0.2
  1. test\nuts.jl\nuts.jl:21
  Expression: ≈(mean(v.s[1000:end]), 49 / 24, atol=0.2)
   Evaluated: 2.263260687797527 ≈ 2.0416666666666665 (atol=0.2)

I am not quite sure what is the proper criteria values for these tests, any help?

@yebai yebai merged commit e585eea into master Mar 22, 2019
@yebai
Copy link
Member

yebai commented Mar 22, 2019 •
edited
Loading

I am not quite sure what is the proper criteria values for these tests, any help?

It's ok - these tests should have been placed in the numerical stage so that their failure won't affect CI. Thanks, @KDr2.

@yebai yebai deleted the 567-again branch March 22, 2019 21:36
@yebai yebai mentioned this pull request Mar 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yebai yebai yebai approved these changes

+1 more reviewer

@mohdibntarek mohdibntarek mohdibntarek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KDr2 @yebai @mohdibntarek