Clean up old code #2574
Merged
Clean up old code #2574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Turing.jl documentation for PR #2574 is available at: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #2574 +/- ##
============================================
+ Coverage 85.86% 86.59% +0.72%
============================================
Files 21 19 -2
Lines 1429 1417 -12
============================================
Hits 1227 1227
+ Misses 202 190 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Worth tagging @yebai for the export of |
yebai
approved these changes
Jun 3, 2025
penelopeysm
added a commit
that referenced
this pull request
Jun 5, 2025
* [skip ci] Bump minor version * Clean up old code (#2574) * Remove src/essential and deprecated function stubs * Fix imports * Export `@addlogprob!` * Fix more tests * Clean up more stuff * Update to the [email protected] interface (#2506) * update to match the [email protected] interface * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * remove plotting * fix formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * remove unused dependency * Update Project.toml * fix make some arugments of vi initializer to be optional kwargs * remove tests for custom optimizers * remove unused file * Update src/variational/bijectors.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update Turing.jl * fix remove call to `AdvancedVI.turnprogress`, which has been removed * apply comments from @yebai * Update src/variational/VariationalInference.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add old interface as deprecated * bump AdvancedVI version * add deprecation for `meanfield` * add `default_rng` interfaces * add tests for variational inference * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * remove "src/variational/bijectors.jl" (moved to `DynamicPPL.jl`) * add more tests for variational inference initializer * remove non-essential reexports, fix tests * run formatter, rename functions * add documentation * fix run formatter * fix remove debug commits * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * run formatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add Variational submodule * fix docstring style * update docstring style * format docstring style * fix typo Co-authored-by: Penelope Yong <[email protected]> * fix use fixed seed with StableRNGs * fix export variational families * fix forma Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update changelog for advancedvi 0.4 * fix version number * Format & add some links * fix formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hong Ge <[email protected]> Co-authored-by: Penelope Yong <[email protected]> * [no ci] fix changelog --------- Co-authored-by: Kyurae Kim <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hong Ge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
src/deprecated.jl, which contained no usable functionality, just some nice warnings for some very old AD backend manipulation utilities.Removes
src/essentialeither through deletion or by moving particle MCMC code tosrc/mcmc/particle_mcmc.jl, as described in Get rid of src/essential #2512Fixed all the imports that needed to be changed as a result of that
Removes
test/skippedwhich just contained a lot of dead codeProperly exports
@addlogprob!, even if it was technically never exported, many people use it so I think we owe it to our users to make it part of the interface.Closes #2512