Change GHA macOS architecture to aarch64 #2395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2395 +/- ##
=======================================
Coverage 86.41% 86.41%
=======================================
Files 22 22
Lines 1575 1575
=======================================
Hits 1361 1361
Misses 214 214 ☔ View full report in Codecov by Sentry. |
mhauru
approved these changes
Nov 27, 2024
Member
mhauru
left a comment
mhauru
left a comment
There was a problem hiding this comment.
Nice catch! Does this need to be changed in other repos too?
Member
Author
|
Indeed it does |
Pull Request Test Coverage Report for Build 12051601116Details
💛 - Coveralls |
sunxd3
added a commit
to TuringLang/JuliaBUGS.jl
that referenced
this pull request
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months ago (I think) GitHub updated their
macos-latestrunners to use Apple Silicon.Since then, we've apparently been testing x64 Julia on an ARM runner which basically runs Julia via Rosetta emulation.
This PR fixes it.
cf. JuliaLang/www.julialang.org#2196 and JuliaLang/julia#55878