Skip to content

Conversation

@torfjelde
Copy link
Member

@torfjelde torfjelde commented May 17, 2024

This includes a few breaking changes + some fixes.

Of greatest importance is:

  • prob"..." macro is gone.
  • Definitions of the form @model demo(::Type{T}=...) are now converted into demo(::TypeWrap{T}=...) to improve type-stability and thus performance. But this means that one can no longer call demo(Vector{Float64}) but instead need to do demo(TypeWrap{Vector{Float64}}()).

Close #2220

@yebai
Copy link
Member

yebai commented May 17, 2024

Should demo(TypeWrap{Float64}())be demo(TypeWrap{Vector{Float64}}())?

@torfjelde
Copy link
Member Author

Yep! Edited.

@torfjelde
Copy link
Member Author

But we need to merge TuringLang/DynamicPPL.jl#609 first

@yebai
Copy link
Member

yebai commented May 17, 2024

Is the old syntax no longer supported, or just inefficient due to type instability?

@torfjelde
Copy link
Member Author

Is the old syntax no longer supported, or just inefficient due to type instability?

Old syntax is still supported for definition, but not for calling.

@yebai
Copy link
Member

yebai commented May 17, 2024

See TuringLang/DynamicPPL.jl#610

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9130206833

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 9125944285: 0.0%
Covered Lines: 0
Relevant Lines: 1528

💛 - Coveralls

@torfjelde
Copy link
Member Author

Anyone wants to give this the go-ahead?

@torfjelde
Copy link
Member Author

Waiting with the merge until I've gotten the other two PRs through, as they are not breaking (but need to fix tests)

@torfjelde torfjelde merged commit a8f1bbc into master May 18, 2024
@torfjelde torfjelde deleted the torfjelde/dppl-0.27 branch May 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants