Libtask Integration #1766
Merged
Libtask Integration #1766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Project.toml * Update Project.toml * Update Project.toml * trace down into functions calling produce * trace into functions in testcases * update to the latest version * run tests against new libtask * temporarily disable 1.3 for testing * Update AdvancedSMC.jl * Update AdvancedSMC.jl * Update AdvancedSMC.jl * Update AdvancedSMC.jl * Update AdvancedSMC.jl * copy Trace on tape * Implement simplified evaluator for TracedModel * Remove some unnecessary trace functions. * Minor bugfix in TracedModel evaluator. * Update .github/workflows/TuringCI.yml * Minor bugfix in TracedModel evaluator. * Update container.jl * Update Project.toml * Commented out tests related to control flow. TuringLang/Libtask.jl/issues/96 * Commented out tests related to control flow. TuringLang/Libtask.jl/issues/96 * Update Project.toml * Update src/essential/container.jl * Update AdvancedSMC.jl Co-authored-by: KDr2 <[email protected]>
…kage test, (keep existing compat) (#1765) Co-authored-by: CompatHelper Julia <[email protected]>
yebai
force-pushed
the
libtask-integration
branch
2 times, most recently
from
47d4b4a to
b9f180a
Compare
devmotion
reviewed
Jan 25, 2022
yebai
force-pushed
the
libtask-integration
branch
3 times, most recently
from
afe6b5d to
f87f455
Compare
devmotion
reviewed
Jan 26, 2022
* fixed dot_assume for hmc * copy-pasted tests from dynamicppl integration tests * inspecting what in the world is going on with tests * trying again * skip failing test for TrackerAD * bump patch version * fixed typo in tests * Rename `Turing.Core` to `Turing.Essential` * Deprecate Turing.Core Co-authored-by: Tor Erlend Fjelde <[email protected]> * fixed a numerical test * version bump Co-authored-by: David Widmann <[email protected]> Co-authored-by: David Widmann <[email protected]>
yebai
force-pushed
the
libtask-integration
branch
from
0d84a5b to
f82b3ea
Compare
… into libtask-integration
… into libtask-integration
… into libtask-integration
yebai
force-pushed
the
libtask-integration
branch
from
08a39de to
27a8d85
Compare
Member
Author
|
With TuringLang/Libtask.jl#107, only one test is failing now! |
distribution tests more robust.
yebai
force-pushed
the
libtask-integration
branch
from
8063ce9 to
675f7cb
Compare
devmotion
reviewed
Jan 26, 2022
Co-authored-by: David Widmann <[email protected]>
devmotion
reviewed
Jan 26, 2022
Co-authored-by: David Widmann <[email protected]>
Member
Author
|
A few tests are still failing for Julia 1.6 due to tight error bounds. The random seed that works for Julia 1.7 turns out not to work well for Julia 1.6. The results are pretty close but still erroring due to current tight error bounds. Maybe we should relax the error threshold for the sensitive tests or increase the number of samples (which leads to a longer CI time). Note these falling tests are mostly related to gradient-based samplers, which is independent of changes in this PR. |
Member
|
Maybe we could use StableRNGs? There was a major change of the RNG in 1.7, and generally random numbers are not guaranteed to be reproducible with different Julia versions, OS, or architectures. |
yebai
force-pushed
the
libtask-integration
branch
from
e71cff3 to
b20224d
Compare
devmotion
reviewed
Jan 30, 2022
yebai
force-pushed
the
libtask-integration
branch
from
b20224d to
e63b5b2
Compare
yebai
force-pushed
the
libtask-integration
branch
from
e63b5b2 to
aa8cc6d
Compare
Co-authored-by: David Widmann <[email protected]>
yebai
force-pushed
the
libtask-integration
branch
3 times, most recently
from
1122a11 to
8bdb54b
Compare
yebai
force-pushed
the
libtask-integration
branch
from
8bdb54b to
877e1fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1766 +/- ##
==========================================
+ Coverage 81.87% 81.90% +0.03%
==========================================
Files 24 24
Lines 1473 1487 +14
==========================================
+ Hits 1206 1218 +12
- Misses 267 269 +2
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1773535676
💛 - Coveralls |
This was referenced Jan 31, 2022
Closed
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of #1757. Awaiting for a new Libtask release before merging.