-
Notifications
You must be signed in to change notification settings - Fork 230
Bump DynamicPPL to 0.16 #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DynamicPPL to 0.16 #1739
Conversation
Project.toml
Outdated
| DistributionsAD = "0.6" | ||
| DocStringExtensions = "0.8" | ||
| DynamicPPL = "0.15" | ||
| DynamicPPL = "0.15, 0.16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly a stupid question, but shouldn't this be pinned to only 0.16 to avoid having to support two versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not an issue as long as it's not a lie, i.e. we're actually compatible with both.
And the idea isn't to have to support two versions: if it turns out that 0.15 doesn't work anymore, then we just remove the compat entry.
EDIT: There were some changes here that are incompatible with DPPL 0.15 though, so I've made this 0.16.
|
Is this PR a duplicate of #1726? |
No. That's for DPPL 0.17. I just realized we never actually updated Turing to allow DPPL 0.16, which is what this PR does. |
Codecov Report
@@ Coverage Diff @@
## master #1739 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 24 24
Lines 1476 1476
=======================================
Hits 1198 1198
Misses 278 278
Continue to review full report at Codecov.
|
No description provided.