Skip to content

Conversation

@torfjelde
Copy link
Member

No description provided.

Project.toml Outdated
DistributionsAD = "0.6"
DocStringExtensions = "0.8"
DynamicPPL = "0.15"
DynamicPPL = "0.15, 0.16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly a stupid question, but shouldn't this be pinned to only 0.16 to avoid having to support two versions?

Copy link
Member Author

@torfjelde torfjelde Dec 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an issue as long as it's not a lie, i.e. we're actually compatible with both.

And the idea isn't to have to support two versions: if it turns out that 0.15 doesn't work anymore, then we just remove the compat entry.

EDIT: There were some changes here that are incompatible with DPPL 0.15 though, so I've made this 0.16.

@yebai
Copy link
Member

yebai commented Dec 10, 2021

Is this PR a duplicate of #1726?

@torfjelde
Copy link
Member Author

Is this PR a duplicate of #1726?

No. That's for DPPL 0.17. I just realized we never actually updated Turing to allow DPPL 0.16, which is what this PR does.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1739 (087b6f6) into master (b5042d6) will not change coverage.
The diff coverage is 44.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1739   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          24       24           
  Lines        1476     1476           
=======================================
  Hits         1198     1198           
  Misses        278      278           
Impacted Files Coverage Δ
src/modes/ModeEstimation.jl 83.73% <20.00%> (ø)
src/inference/ess.jl 97.95% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d4071...087b6f6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants