-
Notifications
You must be signed in to change notification settings - Fork 230
Upper-bound DPPL to remove most recent compiler change #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
+ Coverage 73.37% 78.08% +4.71%
==========================================
Files 24 23 -1
Lines 1292 1424 +132
==========================================
+ Hits 948 1112 +164
+ Misses 344 312 -32
Continue to review full report at Codecov.
|
|
@devmotion Tests are running like 10mins faster here compared to #1577 , so we're looking at a ~15% slowdown? |
|
Is this relative increase consistent with the timings in your experiments? |
1 similar comment
|
Is this relative increase consistent with the timings in your experiments? |
|
Was difficult to see a significant slowdown in those experiments. We observed a ~15% slowdown for |
|
I am a bit surprised though since my impression was that it was mainly compile time regressions. So I assumed it would have a smaller impact in the tests since we use the same model repeatedly. |
|
I guess we didn't check AD-related stuff :/ E.g. maybe Zygote is significantly slower? Anyways, it's probably a good idea to run the benchmarks present in https://github.com/TuringLang/TuringExamples for the different versions and see if we can find something clearcut. In the meantime, can we try to get the outstanding PRs merged? E.g. bump AbstractMCMC versions across the board and merge #1567 ? |
Sure, let's finish these other PRs. |
No description provided.