Twin PR to DPPL 191 #1465
Merged
Twin PR to DPPL 191 #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
requested changes
Nov 21, 2020
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
Looks good, just bump the version, both of Turing and DynamicPPL 😛 At least for DynamicPPL this is mandatory 🙂
Member
|
Should we do the same with this @devmotion ? And bound the DPPL version accordingly? |
Member
|
Yes but maybe let's wait for JuliaRegistries/General#26292. |
devmotion
approved these changes
Dec 12, 2020
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
LGTM, I just updated the Project.toml files.
Pull Request Test Coverage Report for Build 417832618
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
+ Coverage 68.10% 68.13% +0.03%
==========================================
Files 24 24
Lines 1345 1337 -8
==========================================
- Hits 916 911 -5
+ Misses 429 426 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some methods that should be implemented in DynamicPPL and were implemented in TuringLang/DynamicPPL.jl#191.