Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Sep 3, 2025

Closes #487

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.03%. Comparing base (a45c09e) to head (cc22cbd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   86.01%   86.03%   +0.02%     
==========================================
  Files          20       20              
  Lines        1144     1146       +2     
==========================================
+ Hits          984      986       +2     
  Misses        160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

MCMCChains.jl documentation for PR #488 is available at:
https://TuringLang.github.io/MCMCChains.jl/previews/PR488/

@penelopeysm penelopeysm marked this pull request as ready for review September 3, 2025 22:56
@penelopeysm
Copy link
Member Author

penelopeysm commented Sep 3, 2025

@joelkandiah Would you be able to test if this PR works correctly? I think the following workflow should be fine with this PR:

using Turing, Test # and anything else you need

chn = sample(model, spl, MCMCThreads(), N1, M; save_state=true)

# do some sanity checks
@test chn.info.samplerstate isa AbstractVector
@test length(chn.info.samplerstate) == M

chn2 = sample(model, spl, MCMCThreads(), N2, M; initial_state=chn.info.samplerstate)

@joelkandiah
Copy link

Ran the checks and a few others and am happy this is working as intended!

@joelkandiah joelkandiah self-requested a review September 4, 2025 08:49
@penelopeysm penelopeysm merged commit de2d3ec into main Sep 4, 2025
10 checks passed
@penelopeysm penelopeysm deleted the py/samplerstate branch September 4, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with save_state only returning one state instead of one state per chain

3 participants