-
Notifications
You must be signed in to change notification settings - Fork 9
use memory layout info to copy task #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yebai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, @KDr2 - looks good! I left some minor comments below.
Also, I would suggest that we keep the memlayout.cpp file under Libtask_jll. Assuming that we need to re-run memlayout inside a Github workflow, in order to get the member layout for a new Julia release, we can import Libtask_jll. However, this step can be done after the code becomes more mature to avoid frequent changes to Libtask_jll during the development phase.
0bdbb43 to
2f200b2
Compare
|
Now, it's ready to be reviewed and merged. |
yebai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall - one minor comment: maybe create a subfolder in workflows for tasklayout and store the Julia script and cpp source file inside tasklayout?
@devmotion This PR is attempting to crate a more maintainable version of Libtask by doing most of the task struct manipulation operations on the Julia side, and minimise the operations on the C side (i.e. in Libtask_jll). The solution here is not yet perfect, but operational, and already more generic than the current mechanism (e.g. it works correctly on Julia v.1.5.4 and v1.5.3). Can you take a look and see whether you have any comments?
Done. |
No description provided.