Skip to content

Conversation

@KDr2
Copy link
Member

@KDr2 KDr2 commented Nov 26, 2020

Not ready to merge until JuliaPackaging/Yggdrasil#2176 is merged.

@KDr2 KDr2 requested a review from devmotion November 26, 2020 07:17
@KDr2 KDr2 requested a review from devmotion November 26, 2020 15:22
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I guess we have to wait until Julia 1.6 is released (or at least one can build binaries for Julia 1.6 on Yggdrasil).

On the other hand, it does not break anything on Julia < 1.6 and only improves the code, so we could also merge it now. It is just not guaranteed that these fixes are sufficient for Julia 1.6.

@KDr2
Copy link
Member Author

KDr2 commented Nov 26, 2020

On the other hand, it does not break anything on Julia < 1.6 and only improves the code, so we could also merge it now.

Agree.

It is just not guaranteed that these fixes are sufficient for Julia 1.6.

I ran the unit tests locally (on linux) with the updated C source, all of them passed.

So it seems that this PR can be merged now.

@devmotion
Copy link
Member

Good I trust you 🙂 And if we notice any problems in the future, we can always make a bugfix release.

I guess it would be useful to make a release right away if people want to use it with Julia master (even though I don't think it's very likely since they would have to build everything manually)?

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @KDr2!

@yebai yebai merged commit 4e8dda9 into master Nov 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the julia-1.6-compat branch November 26, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants