-
Notifications
You must be signed in to change notification settings - Fork 9
make Libtask compatible with Julia 1.6 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
feba11e to
a23e3d9
Compare
devmotion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I guess we have to wait until Julia 1.6 is released (or at least one can build binaries for Julia 1.6 on Yggdrasil).
On the other hand, it does not break anything on Julia < 1.6 and only improves the code, so we could also merge it now. It is just not guaranteed that these fixes are sufficient for Julia 1.6.
Agree.
I ran the unit tests locally (on linux) with the updated C source, all of them passed. So it seems that this PR can be merged now. |
|
Good I trust you 🙂 And if we notice any problems in the future, we can always make a bugfix release. I guess it would be useful to make a release right away if people want to use it with Julia master (even though I don't think it's very likely since they would have to build everything manually)? |
yebai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @KDr2!
Not ready to merge until JuliaPackaging/Yggdrasil#2176 is merged.