Skip to content

Fix for check_model on arrays with undef #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2024
Merged

Fix for check_model on arrays with undef #608

merged 2 commits into from
May 17, 2024

Conversation

@torfjelde
Copy link
Member

@torfjelde torfjelde commented May 17, 2024

Supersedes #607.

@torfjelde torfjelde mentioned this pull request May 17, 2024
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

Pull Request Test Coverage Report for Build 9126258509

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.57%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 9126213178: -0.1%
Covered Lines: 2634
Relevant Lines: 3440
💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9126267905

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.57%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 9126213178: -0.1%
Covered Lines: 2634
Relevant Lines: 3440
💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

Pull Request Test Coverage Report for Build 9126258509

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.57%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 9126213178: -0.1%
Covered Lines: 2634
Relevant Lines: 3440
💛 - Coveralls

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

Pull Request Test Coverage Report for Build 9126258509

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.57%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 9126213178: -0.1%
Covered Lines: 2634
Relevant Lines: 3440
💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9126258509

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 76.57%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 9126213178: -1.0%
Covered Lines: 2634
Relevant Lines: 3440
💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

Pull Request Test Coverage Report for Build 9126258509

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 77.479%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 9126213178: -0.09%
Covered Lines: 2649
Relevant Lines: 3419
💛 - Coveralls

@coveralls
Copy link

coveralls commented May 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9126267905

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 77.479%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/debug_utils.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 9126213178: -0.09%
Covered Lines: 2649
Relevant Lines: 3419
💛 - Coveralls

@torfjelde
Copy link
Member Author

torfjelde commented May 17, 2024

@yebai @sunxd3

@sunxd3
Copy link
Member

sunxd3 commented May 17, 2024

Looks good

@torfjelde torfjelde enabled auto-merge May 17, 2024 10:25
@torfjelde torfjelde added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 278a82a May 17, 2024
@torfjelde torfjelde deleted the torfjelde/debugutils-fixes-v2 branch May 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunxd3 sunxd3 sunxd3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@torfjelde @coveralls @sunxd3