[Merged by Bors] - Fix anonymous argument with type parameter

[devmotion]

Fixes #393.

Well, it fixes the error but evaluation does not work it seems.

cc: @torfjelde

[yebai]

Looks good - thanks, @devmotion.

[yebai]

bors r+

[yebai]

bors cancel

[bors]

Canceled.

[yebai]

bors try

[devmotion]

The PR doesn't work (yet) - when constructing the model in the example it will store ispredict::Bool instead of a Val.

[bors]

try

Build failed:

• test (1, ubuntu-latest, x86, 2)

[devmotion]

I think we might have to change our handling of arguments a bit and just store unnamed arguments with a gensymed name in the Model. There is no clear mapping between static type parameters and arguments, so I assume (haven't checked yet) it's easy to come up with other bug reports. (I also think it's easy to break stuff with kwargs and provoke undesired method redefinitions, so I assume we should keep positional and keyword arguments separate in the Model).

[yebai]

change our handling of arguments a bit and just store unnamed arguments with a gensymed name in the Model.

That sounds like a sensible plan. More generally, I think we should aim for a more modular, less magical implementation of the @mode macro. It might be a good idea to open a new issue, and list some desirable objectives of a "perfect" model macro.

cc @rikhuijzer

[devmotion]

Arguably it's already quite simple and non-magical, apart from these unnamed arguments. It definitely became much much simpler already. There's not many transformations of the user-specified functions anymore, we just replace the tilde statements (there are separate functions for undotted and dotted tildes) and add our internal arguments. IMO the complexity is mainly/only due to the runtime dispatches in the context pipeline (which is separate from @model).

[devmotion]

bors try

[bors]

try

Build failed:

• test (1, macOS-latest, x64, 2)

[devmotion]

bors r+

[bors]

Pull request successfully merged into master.

Build succeeded:

• docs
• format
• test (1.3, ubuntu-latest, x64, 1)
• test (1.3, ubuntu-latest, x64, 2)
• test (1, macOS-latest, x64, 2)
• test (1, ubuntu-latest, x64, 1)
• test (1, ubuntu-latest, x64, 2)
• test (1, ubuntu-latest, x86, 2)
• test (1, windows-latest, x64, 2)
• Turing.jl

[torfjelde]

Awesome stuff @devmotion ❤️

[phipsgabler]

Uh, finally someone doing this :D Thanks @devmotion, where would be be without you...