[Merged by Bors] - Remove __rng__ and __sampler__ from INTERNALNAMES
#312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names automatically
yebai
approved these changes
Aug 23, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
BTW, I created this PR (almost) only through the new codespaces editor. Surprisingly seamless. (But it involved only copy/pasting two lines.) |
devmotion
reviewed
Aug 23, 2021
devmotion
requested changes
Aug 23, 2021
Co-authored-by: David Widmann <[email protected]>
devmotion
approved these changes
Aug 23, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
Cf. [this discussion](#253 (comment)). Also, derive deprecated names automatically. In the next breaking release we could completely get rid of `DEPRECATED_INTERNALNAMES`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
__rng__ and __sampler__ from INTERNALNAMES__rng__ and __sampler__ from INTERNALNAMES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. this discussion. Also, derive deprecated names automatically.
In the next breaking release we could completely get rid of
DEPRECATED_INTERNALNAMES.