[Merged by Bors] - Introducing AbstractPPL dependency #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Mar 18, 2021
devmotion
reviewed
Mar 18, 2021
devmotion
reviewed
Mar 18, 2021
devmotion
reviewed
Mar 18, 2021
devmotion
reviewed
Mar 18, 2021
devmotion
reviewed
Mar 18, 2021
devmotion
requested changes
Mar 28, 2021
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
I'll approve the PR if the version is bumped and the comments are addressed 🙂 Then we can merge and release the changes.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
This has three very rudimentary consequences: - `VarName` and its helpers are moved over to AbstractPPL completely - The new abstract base type for models is `AbstractPPL.AbstractProbabilisticProgram <: AbstractMCMC.AbstractModel` - `AbstractVarInfo <: AbstractPPL.AbstractModelTrace` More abstractions (and hopefully concrete generalizations, too) are about to come.
Contributor
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has three very rudimentary consequences:
VarNameand its helpers are moved over to AbstractPPL completelyAbstractPPL.AbstractProbabilisticProgram <: AbstractMCMC.AbstractModelAbstractVarInfo <: AbstractPPL.AbstractModelTraceMore abstractions (and hopefully concrete generalizations, too) are about to come.