Skip to content

[Merged by Bors] - generated_quantities and fix for #167 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - generated_quantities and fix for #167 #168

wants to merge 4 commits into from

Conversation

@torfjelde
Copy link
Member

@torfjelde torfjelde commented Sep 28, 2020

This PR adds generated_quantities as discussed in TuringLang/Turing.jl#1335 + adds a fix for #167.

@torfjelde torfjelde mentioned this pull request Sep 28, 2020
Closed
devmotion
devmotion reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments 🙂

devmotion
devmotion reviewed Sep 28, 2020
View reviewed changes
devmotion
devmotion approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I guess you can trigger bors, and then we could make a new release with both this and the other PR (if tests of both are successful)?

@devmotion
Copy link
Member

devmotion commented Sep 28, 2020

I guess we keep the name generated_quantities for now?

@torfjelde
Copy link
Member Author

torfjelde commented Sep 28, 2020

Looks good!

Great! What do I do?! bors+ or something?

I guess we keep the name generated_quantities for now?

Sure 👍 We can easily deprecate and rename later if people find it more confusing than helpful.

@torfjelde
Copy link
Member Author

torfjelde commented Sep 28, 2020

bors +r

@bors
Copy link
Contributor

bors bot commented Sep 28, 2020

Did you mean "r+"?

@torfjelde
Copy link
Member Author

torfjelde commented Sep 28, 2020

bors r+

@torfjelde
Copy link
Member Author

torfjelde commented Sep 28, 2020

Am I doing this correctly @devmotion ? I THINK I've now "queued" both PRs, so bors will now check if they're compatible by putting them into staging branch?

@devmotion
Copy link
Member

devmotion commented Sep 28, 2020

Yes, that's fine. bors puts them in a queue and checks them in a separate staging branch (and hopefully) merges on after another into master, with the second PR taking into account the changes of the first one.

bors bot pushed a commit that referenced this pull request Sep 28, 2020
@torfjelde
generated_quantities and fix for #167 (#168)
161f820 
This PR adds `generated_quantities` as discussed in TuringLang/Turing.jl#1335 + adds a fix for #167.
@bors
Copy link
Contributor

bors bot commented Sep 28, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title generated_quantities and fix for #167 [Merged by Bors] - generated_quantities and fix for #167 Sep 28, 2020
@bors bors bot closed this Sep 28, 2020
@bors bors bot deleted the tor/generated-quantities branch September 28, 2020 03:14
@devmotion devmotion mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmotion devmotion devmotion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@torfjelde @devmotion