Skip to content

Make Sampler a field of DefaultContext (renamed to SamplingContext) #80

@mohdibntarek

Description

@mohdibntarek

Currently we have 2 arguments for changing the behavior of assume and observe, context and sampler. I think:

  1. Sampler belongs in a field in DefaultContext, perhaps renaming it to SamplingContext,
  2. SampleFromPrior should always overwrite the values in VarInfo much like SampleFromUniform in Fix SampleFromUniform #78, and
  3. ComputeLogpContext can be another context which encompasses LikelihoodContext, PriorContext and the current behavior of DefaultContext with SampleFromPrior.

I always found it confusing the SampleFromPrior doesn't actually sample anything if VarInfo already has values.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions