Add quality tests #431
Merged
Add quality tests #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
requested changes
Apr 26, 2025
Member
penelopeysm
left a comment
penelopeysm
left a comment
There was a problem hiding this comment.
Generally, I prefer the explicit if... else... end expressions
penelopeysm
approved these changes
Apr 26, 2025
Member
penelopeysm
left a comment
penelopeysm
left a comment
There was a problem hiding this comment.
Thank you for adding these :)
Is the failure on 1.12 expected?
Collaborator
Author
|
Yeah, the failures on 1.12 are expected |
Member
|
Thanks @ErikQQY and @penelopeysm. Please feel free to merge once you have two independent approvals! |
yebai
approved these changes
Apr 26, 2025
devmotion
reviewed
Jun 5, 2025
| Vector{P}(undef, n_steps) | ||
| else | ||
| z | ||
| Vector{P}(undef, 1) |
Member
There was a problem hiding this comment.
Why was this changed? This creates unnecessary allocations in every step. There's no type inference issue here since FullTraj is a type parameter of a Val, so the compiler compiles and optimizes separate methods for FullTraj = true and FullTraj = false where these branches are eliminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps remove potential bugs and type instabilities