Completely rework monitor handling of Object and Arrays #1113
+35
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarboMuffin
reviewed
Nov 18, 2025
| } | ||
| }; | ||
|
|
||
| module.exports = { |
Member
There was a problem hiding this comment.
no reason to use module.exports instead of es6 modules
Member
There was a problem hiding this comment.
i also think it should just be in monitor adapter we are not really benefitting from bringing this out to another file
Member
There was a problem hiding this comment.
ok you could argue that it might be used somewhere else in the future. in that case let's rename it from sanitize to something else. sanitize implies some security stuff that this isn't doing. maybe tw-safe-stringify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was ported over from NitroBolt
It handles variable monitors and lists better, and doesn't do that weird thing to arrays.