Skip to content

upgrade gradle wrapper to 8.5 #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2023
Merged

upgrade gradle wrapper to 8.5 #971

merged 4 commits into from
Dec 1, 2023

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Nov 30, 2023

No description provided.

@Taz03 Taz03 requested review from a team as code owners November 30, 2023 07:35
@Taz03 Taz03 self-assigned this Nov 30, 2023
@SquidXTV
Copy link
Member

SquidXTV commented Nov 30, 2023 •
edited
Loading

Could it be that you need to reload gradle once in order to install new gradle wrapper jar? Other Gradle upgrades always got changes in the wrapper file

@Taz03 Taz03 marked this pull request as draft November 30, 2023 08:10
@Taz03
Copy link
Member Author

Taz03 commented Nov 30, 2023

tried doing ./gradlew build but nothing happened

@ankitsmt211
Copy link
Member

ankitsmt211 commented Nov 30, 2023 •
edited
Loading

tried doing ./gradlew build but nothing happened

what's the issue here? This is what's recommended if you want the latest version, for specific version you can mention the version. After that you commit the changes.

image

src: https://docs.gradle.org/current/userguide/gradle_wrapper.html#:~:text=Upgrading%20the%20Gradle%20Wrapper,-Projects%20typically%20want&text=One%20way%20to%20upgrade%20the,in%20Adding%20the%20Gradle%20Wrapper.

@SquidXTV
Copy link
Member

tried doing ./gradlew build but nothing happened

You sure you use the wrapper installation instead of your local installation? Check IntelliJ settings, iirc the jar must update too

@Zabuzard
Copy link
Member

yeah. best is to dig out an old PR where we updated gradle already and then follow along

@Taz03
Copy link
Member Author

Taz03 commented Nov 30, 2023

i tried fixing deprecations but these are still left, might want to create an issue for it
image

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Taz03 Taz03 marked this pull request as ready for review November 30, 2023 11:01
@Taz03 Taz03 enabled auto-merge (squash) December 1, 2023 07:25
@Taz03 Taz03 merged commit 59379e6 into develop Dec 1, 2023
@Taz03 Taz03 deleted the upgrade-gradle branch December 1, 2023 08:07
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@SquidXTV SquidXTV SquidXTV approved these changes

Assignees

@Taz03 Taz03

Labels
priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Taz03 @SquidXTV @ankitsmt211 @Zabuzard