-
-
Notifications
You must be signed in to change notification settings - Fork 100
Logging - links logs to source #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogForwarder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogForwarder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogAppender.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/config/Config.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogForwarder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogForwarder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogForwarder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogForwarder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/logging/discord/DiscordLogForwarder.java
Outdated
Show resolved
Hide resolved
Would it be worth adding the source method? If so, we can append it to the end of the URL using Can ignore this suggestion though if we're not proving HTTP links though it might be nice to still have source methods. Up for discussion. |
ah thats nice, I tried to find out how to add the method name as well, but couldnt find a way, |
it doesnt work for me though? |
Kudos, SonarCloud Quality Gate passed! |
Closes #856
About
This feature adds links to the source of a log message forwarded to Discord.
Only happens if source is from
org.togetherjava.tjbot
otherwise ignored.Config
Adds
sourceCodeBaseUrl
to the config.It's used to link the source package + file name e.g.
org.togetherjava.tjbot.features.help.HelpThreadAutoArchiver
to its source.Example:
sourceCodeBaseUrl =
https://github.com/Together-Java/TJ-Bot/blob/master/application/src/main/java/
source =
org.togetherjava.tjbot.features.help.HelpThreadAutoArchiver
-->
https://github.com/Together-Java/TJ-Bot/blob/master/application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadActivityUpdater.java