Update to SlashCommandEducator to exclude strings that end with ")" o…

[tmcdonnell2]

…r ";" from potential incorrect commands. Also, updates to SlashCommandEducatorTest to include new tests.

Closes #804 .

[CLAassistant]

All committers have signed the CLA.

[Zabuzard]

Good stuff. Seems that you have to run spotless for auto-formatting though :)

[tmcdonnell2]

I got the merge going again. I got Spotless working and should now pass. I am unsure about the other workflow programs.

Spotless suggested changing a method in SlashCommandEducator because the parameter being passed in was already a final in the class and thus didn't need to be passed in and could be accessed freely.

One other thing I couldn't figure out (and wasn't sure if it made sense) was to try and make the response ephemeral? I think the classes involved can't do this and I don't know if its what you want.

[Zabuzard]

Thanks, I like it 👍

One other thing I couldn't figure out (and wasn't sure if it made sense) was to try and make the response ephemeral? I think the classes involved can't do this and I don't know if its what you want.

Yeah, thats not possible. Ephemeral only works if you have a client interaction to interact with. For example if the user invoked a slash command, you can respond ephemeral to that. But you can not send ephemeral messages "out of nowhere".

[Zabuzard]

Seems that the unit tests fail for one of the strings:

SlashCommandEducatorTest > sendsAdviceOnMessageCommand(String) > SlashCommandEducatorTest.sendsAdviceOnMessageCommand(String)[7] FAILED

WantedButNotInvoked at SlashCommandEducatorTest.java:49

Seems to be that one: "this is a test;"

Which makes sense, since the regex classifies any message ending with semicolon a non-command. But I think thats also what we want. So maybe move that string to the provideOtherMessages test instead.

[Zabuzard]

awesome! 🎉