SlashCommandEducator should check length #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Abhishek]Add verify the content length
|
|
Taz03
requested changes
Feb 22, 2023
application/src/main/java/org/togetherjava/tjbot/features/basic/SlashCommandEducator.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/togetherjava/tjbot/features/basic/SlashCommandEducatorTest.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Feb 23, 2023
application/src/main/java/org/togetherjava/tjbot/features/basic/SlashCommandEducator.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/togetherjava/tjbot/features/basic/SlashCommandEducatorTest.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/togetherjava/tjbot/features/basic/SlashCommandEducatorTest.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Feb 23, 2023
application/src/test/java/org/togetherjava/tjbot/features/basic/SlashCommandEducatorTest.java
Outdated
Show resolved
Hide resolved
Zabuzard
approved these changes
Feb 23, 2023
|
Awesome stuff. Could you sign the CLA? Then we can proceed 👍 |
Taz03
approved these changes
Feb 23, 2023
|
@abhishekanuj26 Awesome job! Are you also in our Discord server? If so, could you tell me your account name - then I can give you the Contributor role! 👍 |
|
@Zabuzard yep, I am on your discord server. account name - abhishekanuj#0654 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes and fixes #782, lets
SlashCommandEducatoradditionally check the length to prevent false positives. Long messages are not considered a command.