Handling /reminder failure cases #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Zabuzard merged 14 commits into Together-Java:develop from ankitsmt211:develop

Mar 1, 2023

Member

ankitsmt211 commented Feb 20, 2023 •

edited by Zabuzard

Loading

Added a file to alter PENDING_REMINDER_TABLE to add another column REMINDER_FAILURE_COUNTER which keeps track of attempts made when /reminder fails.

Also modified RemindRoutine class to handle failures

Closes and fixes #722

ankitsmt211 added 2 commits

February 20, 2023 21:24


          modified RemindRoutine to handle reminder failure

abf0188


          Merge branch 'develop' of https://github.com/ankitsmt211/TJ-Bot into …

6c69b74

…develop

ankitsmt211 requested review from a team as code owners

February 20, 2023 16:00

CLAassistant commented Feb 20, 2023 •

edited

Loading

All committers have signed the CLA.

Member Author

ankitsmt211 commented Feb 20, 2023

what's happening, is it something wrong with code? not familiar with these automated checks

Member

Taz03 commented Feb 20, 2023

what's happening, is it something wrong with code? not familiar with these automated checks

u can click on details to know what each are about

Zabuzard assigned ankitsmt211

Zabuzard added bug priority: normal labels

Zabuzard requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/resources/db/V13__Add_Reminder_Failure_Counter.sql Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

Member

Zabuzard commented Feb 21, 2023

@ankitsmt211 the issues are mostly related to your code style. u seem to have bypassed the pre-commit hook when u commited and by that skipped spotless. either setup ur pre-commit hooks or run gradle spotless:apply

Taz03 requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved


          modified RemindRoutine to handle failure cases

d3cd1e7

Zabuzard requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved


          modified RemindRoutine to fix bugs and code style

fca7daf

Member Author

ankitsmt211 commented Feb 22, 2023

Please don't run the checks yet, this still needs some work and i had to update the recent changes to my remote repo atm.


          fix : Handle /reminder failures

db769b0

* added Reminder record

* added V13__Add_Reminder_failure_Attempts

* modified RemindRoutine to handle failures

Resolves: #722

ankitsmt211 requested a review from Zabuzard

February 23, 2023 03:47


          Merge branch 'Together-Java:develop' into develop

9577c3d

Taz03 requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/Reminder.java Outdated Show resolved Hide resolved

application/src/main/resources/db/V13__Add_Reminder_Failure_attempts.sql Outdated Show resolved Hide resolved

Zabuzard reviewed

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

Zabuzard requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

ankitsmt211 added 2 commits

February 23, 2023 20:34


          fix Handle /reminder failures

e274257

* adds a column in PENDING_REMINDER

* modifies RemindRoutine to handle failures

Resolves: #722


          fix: handle /reminder failures

6ab9f64

* adds a column for failure attempts in PENDING_REMINDER

* modifies RemindRoutine to handle failure cases

* removes an irrelevant test

Resolves: #722

Zabuzard requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved


          fix: Handle /reminder failures

852f11e

* adds column failure_attempts in PENDING_REMINDER

* removes irrelevant testcase

* modifies RemindRoutine to handle failures

Resolves: #722

Zabuzard requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

ankitsmt211 and others added 2 commits

February 25, 2023 16:12


          Merge branch 'Together-Java:develop' into develop

3fa9cec


          fix: handle /reminder failures

4c2dcd6

* add a column for failure attempts in PENDING_REMINDER

* modify RemindRoutine to handle failure cases

* removes an irrelevant test

Resolves: #722


          Merge branch 'develop' of https://github.com/ankitsmt211/TJ-Bot into …

1aaa3e5

…develop

Taz03 requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Show resolved Hide resolved

ankitsmt211 requested a review from Zabuzard

February 25, 2023 22:13

Zabuzard requested changes

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/reminder/RemindRoutine.java Outdated Show resolved Hide resolved

ankitsmt211 and others added 2 commits

February 27, 2023 21:20


          Merge branch 'Together-Java:develop' into develop

d9f53ed


          fix: Handle /reminder failures

54b5a70

* modify RemindRoutine to handle failure cases

* Update PENDING_REMINDER to keep track of failure_attempts

Resolves: #722

ankitsmt211 requested review from Taz03 and Zabuzard and removed request for Taz03

February 27, 2023 18:57

Zabuzard approved these changes

View reviewed changes

ankitsmt211 requested a review from Taz03

February 28, 2023 11:38

Taz03 approved these changes

View reviewed changes

Zabuzard merged commit 384c66b into Together-Java:develop

Zabuzard mentioned this pull request

Release v4.4 #795

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug priority: normal