Added defer reply to mod commands #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
requested changes
Jan 10, 2023
There was a problem hiding this comment.
to avoid bugs, please dont give all the methods the event but the hook instead. like, everywhere u are passing around event and then do event.getHook().... but instead, just give the methods the hook directly.
that avoids people doing mistakes in those methods.
|
is this required on un-action commands as well like unban, etc? |
|
it wouldnt hurt, i guess. but its less priority, they are not used that often |
|
Kudos, SonarCloud Quality Gate passed! |
Zabuzard
approved these changes
Jan 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added defer reply in mod commands.
closes #712