Prefer uncommon categories first #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Taz03
approved these changes
Dec 15, 2022
|
merging today, so that it makes it into the last release for this year, tomorrow :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements and closes #725.
Fixes the problem that often users tend to select Java as the first category, just because it has to do with Java.
This leads to the Java helpers often being pinged, despite the question is about something more specific. And the actual helpers for this topic not being alerted at all.
Solution
The categories are now selected in reverse-order of the config. Assuming that the config lists them in commonness descending (in particular, Java first).
Now, when an user picks multiple categories:
It will sort the categories by commonness ascending (uncommon first) and pick the first, i.e. the most uncommon, pinging the most specific category: