Fixed bug with help thread creation actions being send too fast #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* delayed by 5 seconds
|
Kudos, SonarCloud Quality Gate passed! |
|
sorta urgent, since it happens multiple times a day right now |
marko-radosavljevic
approved these changes
Dec 13, 2022
Taz03
approved these changes
Dec 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes and closes #723.
This is about a bug happening when our "on-help-thread-created"-actions are executed too fast, after Discord created the thread, but before it send OPs first message. It seems that the whole process does not happen atomic on Discords side, so our actions can slip in-between.
When that happens, we get an exception, cause the first message has to be from OP.
This fixes the issue by delaying sending the messages by 5 seconds, easy.