Skip to content

Conversation

kavink98
Copy link
Contributor

@kavink98 kavink98 commented Dec 7, 2022

Added .vscode to .gitignore for people using VSCode as their IDE

@kavink98 kavink98 requested review from a team as code owners December 7, 2022 13:22
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022

CLA assistant check
All committers have signed the CLA.

Zabuzard
Zabuzard previously approved these changes Dec 7, 2022
@Zabuzard Zabuzard changed the base branch from master to develop December 7, 2022 14:30
@Zabuzard Zabuzard dismissed their stale review December 7, 2022 14:30

The base branch was changed.

@Zabuzard
Copy link
Member

Zabuzard commented Dec 7, 2022

ur PR did target the wrong branch. code is merged towards the develop branch, not master.

Zabuzard
Zabuzard previously approved these changes Dec 7, 2022
Copy link
Contributor

@marko-radosavljevic marko-radosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ☺️ ❤️

Line ending missing at the end of the file.

Also, is that everything that should be ignored for the vscode?

This is a generated template for vscode, the same tool that we used to generate everything else, so consider adding those as well:

# Created by https://www.toptal.com/developers/gitignore/api/visualstudiocode
# Edit at https://www.toptal.com/developers/gitignore?templates=visualstudiocode

### VisualStudioCode ###
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
!.vscode/*.code-snippets

# Local History for Visual Studio Code
.history/

# Built Visual Studio Code Extensions
*.vsix

### VisualStudioCode Patch ###
# Ignore all local history of files
.history
.ionide

@kavink98
Copy link
Contributor Author

kavink98 commented Dec 7, 2022

@marko-radosavljevic I could edit my settings.json and add extensions.json for the recommended extensions. launch.json and tasks.json are not needed in this project as it will be handled by Gradle. I will edit my settings.json to make it generic and push it

Copy link
Contributor

@marko-radosavljevic marko-radosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@marko-radosavljevic marko-radosavljevic merged commit a061b3c into Together-Java:develop Dec 8, 2022
@marko-radosavljevic
Copy link
Contributor

@kavink98 Are you on the server? If you are, give me your discord tag, so I can give you the contributor role. ^^

@Zabuzard Zabuzard mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants