Skip to content

Added list for reminders #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Nov 4, 2022
Merged

Added list for reminders #650

merged 27 commits into from
Nov 4, 2022

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Oct 22, 2022 •
edited
Loading

closes #641

No pending reminders:-
image

Few pending reminders:-
image

Too many pending reminders:-
image
image

@Taz03 Taz03 added new command Add a new command or group of commands to the bot enhance command Modify or improve an existing command or group of commands of the bot priority: low labels Oct 22, 2022
@Taz03 Taz03 requested a review from a team as a code owner October 22, 2022 15:23
@Taz03 Taz03 self-assigned this Oct 22, 2022
@Taz03 Taz03 requested a review from a team as a code owner October 22, 2022 15:23
Zabuzard
Zabuzard requested changes Oct 24, 2022
View reviewed changes
@Taz03 Taz03 requested review from Nxllpointer and Zabuzard October 24, 2022 12:39
Nxllpointer
Nxllpointer requested changes Oct 24, 2022
View reviewed changes
Zabuzard
Zabuzard requested changes Oct 27, 2022
View reviewed changes
Nxllpointer
Nxllpointer requested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@Nxllpointer Nxllpointer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far! Im confident you can make this code really amazing! Also because of renaming the file many of the requested changes may not be caused by you. It would still be really cool if you made it better!

@Taz03 Taz03 requested review from Nxllpointer and Zabuzard October 28, 2022 19:44
@Nxllpointer
Copy link
Contributor

@Taz03 I will approve if we have both settled on a solution for the last open conversation

Nxllpointer
Nxllpointer requested changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@Nxllpointer Nxllpointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect! Also what about our discussion on the button labels?

@Taz03
Copy link
Member Author

Taz03 commented Oct 30, 2022 •
edited
Loading

Also what about our discussion on the button labels?

i mean its a problem with specific person system, so y should i bother about that
anyways did u checked how it looks on mobile?

i have an android i can check on that, do u have an iphone?

@Nxllpointer
Copy link
Contributor

I did check it on my android phone. They got converted to the discord-like emojis but worse. We should just use the discord emojis so it looks the same for everyone

@Taz03
Copy link
Member Author

Taz03 commented Oct 31, 2022

I did check it on my android phone. They got converted to the discord-like emojis but worse. We should just use the discord emojis so it looks the same for everyone

makes sense

Nxllpointer
Nxllpointer previously approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@Nxllpointer Nxllpointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything should be fine now that you changed 👍. Todo: cleanup old code (see resolved conversations)

Zabuzard
Zabuzard requested changes Nov 2, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Taz03 Taz03 requested review from Nxllpointer and Zabuzard November 3, 2022 17:59
@Taz03 Taz03 merged commit a7b7044 into develop Nov 4, 2022
@Taz03 Taz03 deleted the feature/reminder-list branch November 4, 2022 15:44
@Zabuzard Zabuzard mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Tais993 Tais993 Tais993 approved these changes

@Nxllpointer Nxllpointer Awaiting requested review from Nxllpointer

Assignees

@Taz03 Taz03

Labels

enhance command Modify or improve an existing command or group of commands of the bot new command Add a new command or group of commands to the bot priority: low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add /reminders command

4 participants

@Taz03 @Nxllpointer @Zabuzard @Tais993