Skip to content

Fix JOOQ version mismatch #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix JOOQ version mismatch #640

merged 1 commit into from
Oct 17, 2022

Conversation

@Nxllpointer
Copy link
Contributor

@Nxllpointer Nxllpointer commented Oct 17, 2022 •
edited by Zabuzard
Loading

Fixes #639

After the bump to JOOQ gradle plugin 7.1.1 the JOOQ version in application/build/tmp/generateJooq/config.xml changed to 3.16.0. This created a version mismatch with database-settings.gradle that were followed by a few warnings. Intellij would recognize these warnings as errors which was very annoying.

@Nxllpointer
Fix JOOQ version mismatch
5608fd9 
After the bump to JOOQ gradle plugin 7.1.1 the JOOQ version in application/build/tmp/generateJooq/config.xml changed to 3.16.0. This created a version mismatch with database-settings.gradle that were followed by a few warnings. Intellij would recognize these warnings as errors which was very annoying.
@Nxllpointer Nxllpointer requested review from a team as code owners October 17, 2022 11:02
@Nxllpointer Nxllpointer self-assigned this Oct 17, 2022
@Nxllpointer Nxllpointer added bug Something isn't working priority: normal dependencies Pull requests that update a dependency file labels Oct 17, 2022
Zabuzard
Zabuzard approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunate that this wasnt actually considered a compile time error, such that we would have seen it directly in the original dependabot PR

thanks

@Nxllpointer
Copy link
Contributor Author

No problem

This was referenced Oct 17, 2022
Closed
Merged
@Zabuzard
Copy link
Member

lemme speed this up, its just a dep update after all

@Zabuzard Zabuzard merged commit 40eb817 into Together-Java:develop Oct 17, 2022
@Nxllpointer
Copy link
Contributor Author

lemme speed this up, its just a dep update after all

Thank you!

@Nxllpointer Nxllpointer deleted the bugfix/jooq-version-mismatch branch October 17, 2022 12:36
@Zabuzard Zabuzard mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

Assignees

@Nxllpointer Nxllpointer

Labels

bug Something isn't working dependencies Pull requests that update a dependency file priority: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Weird warning since JOOQ plugin version 7.1.1

2 participants

@Nxllpointer @Zabuzard