Implemented modal support #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tais993
force-pushed
the
feature/modal-support
branch
from
7b4e123 to
a2eb314
Compare
Taz03
requested changes
Oct 14, 2022
application/src/main/java/org/togetherjava/tjbot/commands/BotCommandAdapter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/BotCommandAdapter.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Oct 14, 2022
application/src/main/java/org/togetherjava/tjbot/commands/UserInteractor.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/UserInteractor.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/BotCommandAdapter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/BotCommandAdapter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/system/BotCore.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/system/BotCore.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/system/BotCore.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/system/BotCore.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/system/BotCore.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Oct 14, 2022
application/src/main/java/org/togetherjava/tjbot/commands/BotCommandAdapter.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Oct 14, 2022
application/src/main/java/org/togetherjava/tjbot/commands/system/BotCore.java
Outdated
Show resolved
Hide resolved
Taz03
requested changes
Oct 14, 2022
application/src/main/java/org/togetherjava/tjbot/commands/basic/PingCommand.java
Outdated
Show resolved
Hide resolved
Tais993
force-pushed
the
feature/modal-support
branch
from
ec36db7 to
af0336f
Compare
Zabuzard
requested changes
Oct 17, 2022
application/src/main/java/org/togetherjava/tjbot/commands/system/BotCore.java
Outdated
Show resolved
Hide resolved
Tais993
force-pushed
the
feature/modal-support
branch
from
af0336f to
63fae43
Compare
|
since u force pushed on a previous commit instead of creating a third commit, i cant really see what u changed from latest commit that i reviewed. is all that u changed the nonnull thing? or more? |
|
Forgot about the forced squashing, yea only thing I changed was that. |
Taz03
requested changes
Oct 18, 2022
application/src/main/java/org/togetherjava/tjbot/commands/help/HelpPostCreationListener.java
Outdated
Show resolved
Hide resolved
Tais993
force-pushed
the
feature/modal-support
branch
from
63fae43 to
5d25a4f
Compare
Taz03
approved these changes
Oct 19, 2022
Zabuzard
approved these changes
Oct 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added onModal to UserInteractor
Added empty onModal implementation to BotCommandAdapter
Changes to component forwarding BotCore:
added handleGetComponentId
This way a modal can get the ComponentId instance, and the forwardComponentCommand doesn't cease to exist.