Skip to content

Format injection in help thread titles #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Format injection in help thread titles #615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions application/src/main/java/org/togetherjava/tjbot/commands/help/AskCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,11 @@ private RestAction<Message> sendInitialMessage(Guild guild, ThreadChannel thread
.map(role -> " (%s)".formatted(role.getAsMention()))
.orElse("");

String contentPattern = "%s has a question about '**%s**'%%s and will send the details now."
.formatted(author.getAsMention(), title);
String contentWithoutRole = contentPattern.formatted("");
String contentWithRole = contentPattern.formatted(roleMentionDescription);
String contentPrefix =
"%s has a question about '**%s**'".formatted(author.getAsMention(), title);
String contentSuffix = " and will send the details now.";
String contentWithoutRole = contentPrefix + contentSuffix;
String contentWithRole = contentPrefix + roleMentionDescription + contentSuffix;

// We want to invite all members of a role, but without hard-pinging them. However,
// manually inviting them is cumbersome and can hit rate limits.
Expand Down