TopHelpersCommand message is too long #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
force-pushed
the
bugfix/top_helper_too_long
branch
2 times, most recently
from
68a7866 to
3a94d89
Compare
Tais993
reviewed
Oct 10, 2022
application/src/main/java/org/togetherjava/tjbot/commands/tophelper/TopHelpersCommand.java
Show resolved
Hide resolved
Tais993
previously approved these changes
Oct 10, 2022
sure. was just a bit difficult, since i dont have 20+ users on my private server to make the problem obvious. and i was too lazy to mock the DB just for screenshots. and the real tables from PROD contained sensitive info that i also was too lazy to mock lol. but yeah, agreed. |
Taz03
previously approved these changes
Oct 11, 2022
* limit long user names * move description before table * reduce amount of helpers listed
Zabuzard
force-pushed
the
bugfix/top_helper_too_long
branch
from
8cb5b76 to
4944510
Compare
|
just rebased, no code changes. already had 2 approvals. merging once pipeline succeeds |
|
Kudos, SonarCloud Quality Gate passed! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #603 which describes a bug when using
/top-helpersresulting in a too long message, not accepted by Discord.The approach is simple yet effective:
these factors effectively reduced the message that was too long from 2300 characters down to 1100 characters, which is perfectively within limits.
Notes
Since this class also needed abbreviation logic, I elevated the
abbreviatemethod from within theDiscordLogForwardertoMessageUtils. And also gave it a unit test.