Replaced overview message to embed #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tais993
force-pushed
the
bugfix/overview_character_limit
branch
from
745c108 to
eb5a294
Compare
Zabuzard
requested changes
Oct 7, 2022
application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadOverviewUpdater.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadOverviewUpdater.java
Show resolved
Hide resolved
Zabuzard
previously approved these changes
Oct 11, 2022
Tais993
force-pushed
the
bugfix/overview_character_limit
branch
from
6d56d28 to
f4de273
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Taz03
approved these changes
Oct 11, 2022
Zabuzard
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the overview was normal message, but this had the downside of having a limit of 2000 characters.
Embeds have a limit of 4096, which is more than double. But there was a reason for it, embeds didn't have click-through channel mentions on phone.
And that's a major issue, as it'd mean you read the thread channels name, then you find the "Discord" overview, type in the title (assuming you haven't forgotten it), and then you finally reach the channel.
Compared to a simple click, this takes a lot of time.
Since phone now has support for this, there's no reason to not use embeds.
So after this we support more than 2x the amount of questions than before!
Closes #533
This breaks backwards compatibility, the old message has to get deleted.