Auto posting advice on uncategorized help threads #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* after 5 mins
|
Kudos, SonarCloud Quality Gate passed! |
application/src/main/java/org/togetherjava/tjbot/commands/help/HelpSystemHelper.java
Show resolved
Hide resolved
|
one week, no progress. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #487 .
Reminds the user of selecting a category for their help threads if they still dont have one after 5 minutes:
Technically, its solved with a simple scheduled task - scheduled after creation of threads without categories (
ImplicitAskListener).Notes
I put the code for that into
HelpSystemHelpersince the executor service (with 3 threads) should be reused for #481 and similar issues.The ping is outside of the embed to ensure it actually pings the author, instead of just a soft-ping. But I still wanted to keep using the embed instead of a raw message for the better UI.
Before someone asks during CR, there is no overload for
retrieveThreadChannelByIdor similar. JDAs cache seems to be a reliable source for channels, similar to guilds (i.e. JDA seems to receive all updates to them and keeps the cache up2date - unlike for users).