Skip to content

Fix sonar issues #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Fix sonar issues #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52be987
Added documentation and private modifiers
mikerasch Aug 26, 2022
5e1516e
Added more clarity to ensure optimal agreement on the use cases of pa…
mikerasch Aug 27, 2022
34bad5c
Fixed period at the end of the parameter documentation
mikerasch Aug 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion application/src/main/java/org/togetherjava/tjbot/commands/help/HelpSystemHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public final class HelpSystemHelper {
* Creates a new instance.
*
* @param config the config to use
* @param database the database to store help thread metadata in
*/
public HelpSystemHelper(@NotNull Config config, @NotNull Database database) {
HelpSystemConfig helpConfig = config.getHelpSystem();
Expand Down Expand Up @@ -104,7 +105,7 @@ RestAction<Message> sendExplanationMessage(@NotNull MessageChannel threadChannel
return action.setEmbeds(embeds);
}

public void writeHelpThreadToDatabase(Member author, ThreadChannel threadChannel) {
void writeHelpThreadToDatabase(Member author, ThreadChannel threadChannel) {
database.write(content -> {
HelpThreadsRecord helpThreadsRecord = content.newRecord(HelpThreads.HELP_THREADS)
.setAuthorId(author.getIdLong())
Expand Down
5 changes: 5 additions & 0 deletions application/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadMetadataPurger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ public class HelpThreadMetadataPurger implements Routine {
private static final Logger logger = LoggerFactory.getLogger(HelpThreadMetadataPurger.class);
private static final Period DELETE_MESSAGE_RECORDS_AFTER = Period.ofDays(30);

/**
* Creates a new instance.
*
* @param database the database used to purge help thread metadata
*/
public HelpThreadMetadataPurger(@NotNull Database database) {
this.database = database;
}
Expand Down
9 changes: 7 additions & 2 deletions ...n/src/main/java/org/togetherjava/tjbot/commands/help/OnGuildLeaveCloseThreadListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ public class OnGuildLeaveCloseThreadListener extends ListenerAdapter implements
LoggerFactory.getLogger(OnGuildLeaveCloseThreadListener.class);
private final Database database;

/**
* Creates a new instance.
*
* @param database database to use
*/
public OnGuildLeaveCloseThreadListener(@NotNull Database database) {
this.database = database;
}
Expand All @@ -35,15 +40,15 @@ public void onGuildMemberRemove(@Nonnull GuildMemberRemoveEvent leaveEvent) {
}
}

public Set<Long> getThreadsCreatedByLeaver(long leaverId) {
private Set<Long> getThreadsCreatedByLeaver(long leaverId) {
return new HashSet<>(database
.readTransaction(context -> context.select(HelpThreads.HELP_THREADS.CHANNEL_ID))
.from(HelpThreads.HELP_THREADS)
.where(HelpThreads.HELP_THREADS.AUTHOR_ID.eq(leaverId))
.fetch(databaseMapper -> databaseMapper.getValue(HelpThreads.HELP_THREADS.CHANNEL_ID)));
}

public void closeThread(long channelId, @NotNull GuildMemberRemoveEvent leaveEvent) {
private void closeThread(long channelId, @NotNull GuildMemberRemoveEvent leaveEvent) {
ThreadChannel threadChannel = leaveEvent.getGuild().getThreadChannelById(channelId);
if (threadChannel == null) {
logger.warn(
Expand Down